[PATCH] D85456: Fix instruction counting in post-RA scheduler

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 14:42:07 PDT 2020


rampitec added a comment.

In D85456#2201163 <https://reviews.llvm.org/D85456#2201163>, @rampitec wrote:

> In D85456#2201140 <https://reviews.llvm.org/D85456#2201140>, @arsenm wrote:
>
>> In D85456#2201120 <https://reviews.llvm.org/D85456#2201120>, @kerbowa wrote:
>>
>>> Seems wrong to have a bundle without BUNDLE opcode but the change seems fine obviously. Since it's allowed we should probably just account for the possibility.
>>
>> But is it? I think this is a failing of the verifier and it is not allowed
>
> It probably isn't. But there seems to be quite a few places which do not work with properly formed bundles. One of them is ExpandPostRA.

As weird as it sounds VirtRegRewriter::expandCopyBundle() does not work with properly formed bundles as well...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85456/new/

https://reviews.llvm.org/D85456



More information about the llvm-commits mailing list