[PATCH] D85434: BPF: add a SimplifyCFG IR pass during generic Scalar/IPO optimization

[Yonghong Song via llvm-commits]

On 8/6/20 3:36 PM, Thomas Preud'homme via Phabricator wrote:
> thopre added a comment.
> 
> FYI, I've had the following linker error on an incremental error which disappear if I revert this commit:
> 
> BPFTargetMachine.cpp:(.text._ZNSt17_Function_handlerIFvRKN4llvm18PassManagerBuilderERNS0_6legacy15PassManagerBaseEEZNS0_16BPFTargetMachine17adjustPassManagerERS1_EUlS3_S6_E_E9_M_invokeERKSt9_Any_dataS3_S6
> _+0x70): undefined reference to `llvm::createCFGSimplificationPass(llvm::SimplifyCFGOptions, std::function<bool (llvm::Function const&)>)'
> collect2: error: ld returned 1 exit status

Thanks! I just pushed a fix a few minutes back.

commit c50f5dece9728c377e6f77cb3874de2e406c4268 (bug10)
Author: Yonghong Song <yhs at fb.com>
Date:   Thu Aug 6 15:22:03 2020 -0700

     BPF: fix libLLVMBPFCodeGen.so build failure

     Buildbot reported a build failure when building shared
     library libLLVMBPFCodeGen.so with unknown reference to
     "createCFGSimplificationPass".

     Commit 87cba434027b ("BPF: add a SimplifyCFG IR pass during
     generic Scalar/IPO optimization") added an IR pass SimplifyCFG
     by BPF target. The commit called function
     createCFGSimplificationPass() defined in "Scalar" library.
     Add this library in Target/BPF/LLVMBuild.txt so
     shared library build can succeed.

> 
> 
> Repository:
>    rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>    https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D85434_new_&d=DwIFAg&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=Ym3F6042nlN5Mi4MI1FDjgeetqmlhCWXONuK8uSeTP4&s=x9ik_i9rOA5g2TmjVelkWBM4Hdua8EK54hRdhRHH7fs&e=
> 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D85434&d=DwIFAg&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=Ym3F6042nlN5Mi4MI1FDjgeetqmlhCWXONuK8uSeTP4&s=WWh-1_Anyajyz-wwxpq9YOPJFdjbGTNXNSwKzL0IdEQ&e=
>