[PATCH] D85477: Use z instead of ZLIB::ZLIB
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 15:13:44 PDT 2020
lxfind created this revision.
lxfind added reviewers: phosek, wenlei.
Herald added subscribers: llvm-commits, hiraditya, mgorny.
Herald added a project: LLVM.
lxfind requested review of this revision.
With D79219 <https://reviews.llvm.org/D79219>, when building LLVM, the following is seen in file `build_dir/lib/cmake/llvm/LLVMExports.cmake`:
set_target_properties(LLVMSupport PROPERTIES
INTERFACE_LINK_LIBRARIES "curses;m;ZLIB::ZLIB;LLVMDemangle"
We should be consistent in how to set import libs here. Everywhere else we use the short names, such as rt, m and etc.
We should also use z here.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85477
Files:
llvm/lib/Support/CMakeLists.txt
Index: llvm/lib/Support/CMakeLists.txt
===================================================================
--- llvm/lib/Support/CMakeLists.txt
+++ llvm/lib/Support/CMakeLists.txt
@@ -1,5 +1,5 @@
if(LLVM_ENABLE_ZLIB)
- set(imported_libs ZLIB::ZLIB)
+ set(imported_libs z)
endif()
if( MSVC OR MINGW )
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85477.283746.patch
Type: text/x-patch
Size: 306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200806/6858cc24/attachment.bin>
More information about the llvm-commits
mailing list