[PATCH] D85350: [msan] Support %ms in scanf.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 13:56:13 PDT 2020


eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_format.inc:346-349
+      if (buf) {
+        uptr buf_len = internal_strlen(buf) + 1;
+        COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, buf_len);
+      }
----------------
vitalybuka wrote:
> for consistency, we use real for similar stuff in other interceptors and without temp var
This file uses internal_strlen everywhere. I've got rid of the temp variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85350/new/

https://reviews.llvm.org/D85350



More information about the llvm-commits mailing list