[PATCH] D85468: [LegalTypes] Move VSELECT node creation out of WidenVSELECTAndMask and push to 2 of the 3 callers.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 12:48:52 PDT 2020


craig.topper created this revision.
craig.topper added reviewers: efriedma, jnspaulsson, RKSimon, spatel.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
craig.topper requested review of this revision.

One of the callers only wants the condition, but the vselect can
be simplified by getNode making it hard or impossible to retrieve
the condition.

Instead, return the condition and make the other 2 callers
responsible for creating the vselect node using the condition.
Rename the function to WidenVSELECTMask accordingly.

Fixes PR47019


https://reviews.llvm.org/D85468

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/test/CodeGen/SystemZ/pr47019.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85468.283707.patch
Type: text/x-patch
Size: 6853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200806/d27fd5b1/attachment.bin>


More information about the llvm-commits mailing list