[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

Thu Aug 6 12:02:33 PDT 2020

jdoerfert added a comment.

This seems to be related to the push of the `cpu-id` (aka. `target-id`) into other places as well: e.g., D84822 <https://reviews.llvm.org/D84822>, D80750 <https://reviews.llvm.org/D80750>, probably more.
I mentioned in those reviews already, this doesn't strike me as an "AMDGPU" feature at all. 
We should start the discussions around missing functionality instead of adding AMDGPU workarounds in all these places...
One example is an IR module level `target cpu` and/or `target feature`, similar to `target triple`.

---

Also, the commit doesn't have a message that explains what is going on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519