[PATCH] D85173: [zorg] build.py: Allow lit test timeout value to be configurable

[Azharuddin Mohammed via Phabricator via llvm-commits]

azharudd requested changes to this revision.
azharudd added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/jenkins/test_monorepo_build.py:141
+
+#Test to check if timeout flag is actually being set
+# RUN: python %{src_root}/zorg/jenkins/monorepo_build.py cmake all --timeout=900 > %t-timeout.log
----------------
Please follow the convention for the comments (in this case whitespace missing after '#'). 


================
Comment at: test/jenkins/test_monorepo_build.py:146
+
+#Test to check if timeout flag is actually being set
+# RUN: python %{src_root}/zorg/jenkins/monorepo_build.py cmake all > %t-timeout-default.log
----------------
here too ... 
Also please update the comment to reflect what is being tested. 


================
Comment at: zorg/jenkins/monorepo_build.py:1
+
 """Build and test clangs."""
----------------
Extra newline. 


================
Comment at: zorg/jenkins/monorepo_build.py:312
 
-    lit_flags = ['--xunit-xml-output=testresults.xunit.xml', '-v', '-vv', '--timeout=600']
+    lit_flags = ['--xunit-xml-output=testresults.xunit.xml', '-v', '-vv', '--timeout='+str(conf.timeout)]
     if conf.max_parallel_tests:
----------------
Can we move the timeout flag into a separate variable and use that here? 


================
Comment at: zorg/jenkins/monorepo_build.py:452
 
-            lit_flags = ['--xunit-xml-output=testresults.xunit.xml', '-v', '-vv', '--timeout=600']
+            lit_flags = ['--xunit-xml-output=testresults.xunit.xml', '-v', '-vv', '--timeout='+str(conf.timeout)]
+
----------------
same here


================
Comment at: zorg/jenkins/monorepo_build.py:1043
                         help="Semicolon seperated list of projects to build.")
-
+    parser.add_argument('--timeout',dest= 'timeout', type=int, help='job_Timeout', default='600' )
     args = parser.parse_args()
----------------
Please expand the help message. 


================
Comment at: zorg/jenkins/monorepo_build.py:1043
                         help="Semicolon seperated list of projects to build.")
-
+    parser.add_argument('--timeout',dest= 'timeout', type=int, help='job_Timeout', default='600' )
     args = parser.parse_args()
----------------
azharudd wrote:
> Please expand the help message. 
Extra whitespace.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85173/new/

https://reviews.llvm.org/D85173