[PATCH] D85379: Reduce dropTriviallyDeadConstantArrays cumulative time percentage from 17% to 4%
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 10:22:58 PDT 2020
tejohnson added inline comments.
================
Comment at: llvm/lib/IR/LLVMContextImpl.cpp:147
if (auto *COp = dyn_cast<ConstantArray>(Op))
WorkList.insert(COp);
}
----------------
Would it make sense to also guard insertion here with COp->use_empty()? You can then remove the C->use_empty() check earlier in this loop, which is redundant for ConstantArrays inserted by the new loop you added above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85379/new/
https://reviews.llvm.org/D85379
More information about the llvm-commits
mailing list