[PATCH] D85387: [NFC] Make argument name passed to `FindAvailableMemoryRange()` consistent with parameter name.
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 09:36:59 PDT 2020
yln added a reviewer: tejohnson.
yln added a subscriber: tejohnson.
yln added a comment.
I am okay with this change, but I don't understand this code or why this change is NFC. Can we get @tejohnson to take a look? (D83247 <https://reviews.llvm.org/D83247>)
`granularity` is not necessarily equal to `left_padding`. Also `left_padding` already goes into `space_size`, which is also passed to `FindAvailableMemoryRange()`.
const uptr granularity = GetMmapGranularity();
...
const uptr left_padding =
Max<uptr>(granularity, 1ULL << min_shadow_base_alignment);
uptr space_size = shadow_size_bytes + left_padding;
...
uptr shadow_start =
FindAvailableMemoryRange(space_size, alignment, granularity, ...);
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85387/new/
https://reviews.llvm.org/D85387
More information about the llvm-commits
mailing list