[PATCH] D84324: AMDGPU/GlobalISel: Lower G_FREM

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:703-705
+  getActionDefinitionsBuilder(G_FREM)
+    .customFor({S16, S32, S64})
+    .scalarize(0);
----------------
foad wrote:
> Does this need to be conditional on ST.has16BitInsts ?
It doesn't strictly have to be, but it would produce a better result to force promotion to 32-bit first


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84324/new/

https://reviews.llvm.org/D84324