[PATCH] D84249: AMDGPU/GlobalISel: Stop using G_EXTRACT in argument lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp:372
   if (SrcTy.isVector() && !PartTy.isVector() &&
       PartSize > SrcTy.getElementType().getSizeInBits()) {
     // Vector was scalarized, and the elements extended.
----------------
foad wrote:
> SrcTy.getScalarSizeInBits() ?
That is slightly different since it also works for non-vectors, which may be unintentional


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp:389
+  MachineRegisterInfo &MRI = *B.getMRI();
+  LLT DstTy = MRI.getType(DstRegs[0]);
+  LLT LCMTy = getLCMType(SrcTy, PartTy);
----------------
foad wrote:
> Is DstTy ever different from PartTy? If so, what exactly is PartTy?
Yes, PartTy the physical register type, DstTy is the original register type from the IR


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84249/new/

https://reviews.llvm.org/D84249