[PATCH] D85271: AMDGPU/GlobalISel: Make s16 phi legal

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 06:41:04 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:446
   getActionDefinitionsBuilder(G_PHI)
-    .legalFor({S32, S64, V2S16, V4S16, S1, S128, S256})
+    .legalFor({S32, S64, V2S16, S16, V4S16, S1, S128, S256})
     .legalFor(AllS32Vectors)
----------------
foad wrote:
> It doesn't really matter but this seems like an odd place to insert "S16" into the list.
This should probably be replaced with legalIf(isRegisterType(0)) but I'm planning a larger rewrite of all of this stuff


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85271/new/

https://reviews.llvm.org/D85271



More information about the llvm-commits mailing list