[PATCH] D83779: [SLP] Fix order of `insertelement`/`insertvalue` seed operands
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 06:05:13 PDT 2020
RKSimon added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7089
+ if (auto *IE = dyn_cast<InsertElementInst>(InsertInst))
+ return IE->getType()->getNumElements();
+
----------------
VectorType::getNumElements() will be going away soon - you need to replace this with cast<FixedVectorType>(IE->getType())->getNumElements()
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7104
+ CurrentType = AT->getElementType();
+ } else if (auto *VT = dyn_cast<VectorType>(CurrentType)) {
+ AggregateSize *= VT->getNumElements();
----------------
dyn_cast<FixedVectorType>
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7120
+ if (auto *CI = dyn_cast<ConstantInt>(IE->getOperand(2))) {
+ auto *VT = cast<VectorType>(IE->getType());
+ OperandIndex *= VT->getNumElements();
----------------
cast<FixedVectorType>(IE->getType())
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83779/new/
https://reviews.llvm.org/D83779
More information about the llvm-commits
mailing list