[PATCH] D85242: [AArch64] [Windows] Error out on unsupported symbol locations

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 04:49:00 PDT 2020


hans added a comment.

In D85242#2198707 <https://reviews.llvm.org/D85242#2198707>, @mstorsjo wrote:

> @hans - WDYT about backporting this one? It's a little bit risky if the check would turn out to be too strict, but there's been no false positives in my test build corpus (which includes a fair bit of assembly source); the upside is for anybody working on porting (mainly assembly) code that isn't originally written for arm64/windows - as it previously wouldn't error out at build time on constructs that don't exist on windows and won't work as intended at runtime.

I think the risk/reward ratio is decent here. Pushed as 3aec1c6a493f543d41caf99e5df9056776856941 <https://reviews.llvm.org/rG3aec1c6a493f543d41caf99e5df9056776856941>, please shout if you see any problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85242/new/

https://reviews.llvm.org/D85242



More information about the llvm-commits mailing list