[PATCH] D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1620
+        }
+        if (NextStride == 2 && isa<LoadInst>(I)) {
+          LLVM_DEBUG(dbgs() << "Consecutive strides of 2 found, vld2 can't "
----------------
else ifs?


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1625
+        }
+        if (EnableMaskedGatherScatters) {
+          if (NextStride > 0) {
----------------
I think this would be easier to read if this was organised in stride order and separating the gather/scatter from the consecutive accesses. So when !EnableMaskedGatherScatter, getPtrStride should only ever be 1, right? So I don't think we have to track the 'NextStride' business.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85410/new/

https://reviews.llvm.org/D85410