[PATCH] D85313: [DebugInfo] Don't error for zero-length arange entries
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 6 00:00:05 PDT 2020
ikudrin added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp:138-142
if (arangeDescriptor.Length == 0) {
// Each set of tuples is terminated by a 0 for the address and 0
// for the length.
if (arangeDescriptor.Address == 0 && *offset_ptr == end_offset)
return ErrorSuccess();
----------------
- Thought 1: these two `if`s can now be combined into one.
- Thought 2: should not we report the premature termination of the list?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85313/new/
https://reviews.llvm.org/D85313
More information about the llvm-commits
mailing list