[PATCH] D85080: [lld-macho] Support static linking of thread-locals

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputSection.cpp:39
+    if (auto *s = r.target.dyn_cast<Symbol *>()) {
+      va = target->getSymbolVA(buf + r.offset, *s, r.type);
+
----------------
smeenai wrote:
> I'm assuming this should be `resolveSymbolVA`?
yup


================
Comment at: lld/MachO/InputSection.cpp:41
+
+      if (isThreadLocalVariables(flags)) {
+        // References from thread-local variable sections are treated as
----------------
smeenai wrote:
> Is this not being put in `resolveSymbolVA` because it's target-independent?
> 
> Also, this is pretty strange ... I wonder why it's set up like this.
yup, I think it's target-independent


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85080/new/

https://reviews.llvm.org/D85080