[PATCH] D84822: Add target ID to AMDGPU documentation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

The commit does not have a message, contains unrelated parts, and is still not addressing my issues wrt. the description of common functionality as AMDGPU functionality.



================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:88
+in `AMDGPU Embedding Bundled Code Objects
+  <https://llvm.org/docs/AMDGPUUsage.html#embedding-bundled-objects>`_.
----------------
This is not generic and ignores the fact that we use this tool for non-AMDGPU targets. The target-id description above does too.


================
Comment at: llvm/docs/AMDGPUUsage.rst:264
-                                                      [off]
-                                                    - cumode
-                                                      [off]
----------------
None of these changes seem related to "Add target ID to AMDGPU documentation".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822