[PATCH] D85153: [lld-macho] Add .tbd support for frameworks

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM



================
Comment at: lld/MachO/Driver.cpp:115
     path::append(symlink, name + ".framework", name);
     // If the symlink fails to resolve, skip to the next search path.
+
----------------
I think this comment is out of place now?


================
Comment at: lld/MachO/Driver.cpp:123
+        // only append suffix if realpath() succeeds
+        Twine suffixed = location + suffix;
+        if (fs::exists(suffixed))
----------------
Does ld64 also not check for tbds if there's a suffix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85153/new/

https://reviews.llvm.org/D85153