[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:89
+    Optional<uint64_t> Count = MBFI->getBlockProfileCount(&MBB);
+    if (!(Count.hasValue() && Count.getValue() > 0)) {
+      MBB.setSectionID(MBBSectionID::ColdSectionID);
----------------
Add an internal option here (the coldness threshold) for experimental purpose.

I also suggest add an option to specify programSummary based coldness threshold such as 99.99 percentile coldness. The default cutoff is 99.9999% defined in ProfileSummaryInfo.cpp: ProfileSummaryCutoffCold


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368