[PATCH] D84610: [ELF] --icf: don't fold text sections with LSDA
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 5 16:47:02 PDT 2020
MaskRay added a comment.
In D84610#2198195 <https://reviews.llvm.org/D84610#2198195>, @MaskRay wrote:
> In D84610#2198191 <https://reviews.llvm.org/D84610#2198191>, @thakis wrote:
>
>> This probably breaks the build on systems where uint64_t and size_t are different types, such as apparently on macOS:
>>
>> http://45.33.8.238/mac/18492/step_4.txt
>>
>> I'm only seeing this on some of my Macs though, so maybe it's dependent on sdk or host clang version. If the error makes sense to you, do something about it, else I'll try installing a newer host clang on that bot later.
>
> Already fixed by 279e4cf78262dfef560631d643b85aa2032ac566 <https://reviews.llvm.org/rG279e4cf78262dfef560631d643b85aa2032ac566>
I will make a follow-up patch changing these `size_t` to `uint64_t`. They are so error-prone.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84610/new/
https://reviews.llvm.org/D84610
More information about the llvm-commits
mailing list