[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/BBSectionsPrepare.cpp:72
 #include "llvm/ADT/StringRef.h"
+#include "llvm/CodeGen/BasicBlockSectionUtils.h"
 #include "llvm/CodeGen/MachineFunction.h"
----------------
Should we rename the .h and .cpp so that they have the same prefix?  Maybe BasicBlockSections.h and BasicBlockSections.cpp?


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:218
+static cl::opt<bool> EnableMachineFunctionSplitter(
+    "enable-split-machine-functions", cl::Hidden,
+    cl::desc("Split out cold blocks from machine functions based on profile "
----------------
Why not call this split-machine-functions too for consistency?


================
Comment at: llvm/test/CodeGen/X86/machine-function-splitter.ll:8
+; CHECK-NEXT:  foo1.cold:
+; CHECK-NOT:   callq   bar
+  br i1 %0, label %2, label %4, !prof !4
----------------
Also, check if the block is moved to the cold region has the expected call instruction?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368