[PATCH] D51922: [NewGVN] Apply SimplifySelectInst if any of the options is undef.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 12:34:54 PDT 2020


fhahn added a comment.

In D51922#2189925 <https://reviews.llvm.org/D51922#2189925>, @mkazantsev wrote:

> Looks good. Is it still not merged? :)

unfortunately I did not really have much time to focus on some of the outstanding NewGVN patches, but finally found some time :)

While this patch on it's own makes sense, it also hides a slightly different problem, but I think we finally have a reasonable approach to fix this other problem more generally (D84792 <https://reviews.llvm.org/D84792>), so I think it should be safe to also land this patch (which is an additional optimization). Thanks for taking a look!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51922/new/

https://reviews.llvm.org/D51922



More information about the llvm-commits mailing list