[PATCH] D85335: [gn] Fix build on macos

[Yannic Bonenberger via Phabricator via llvm-commits]

yannic created this revision.
yannic added a reviewer: thakis.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLVM.
yannic requested review of this revision.

This fixes an error when running `llvm/utils/gn/gn.py gen out/gn` on macos:

  ERROR at //llvm/tools/dsymutil/BUILD.gn:33:14: Unsupported value in libs.
      libs = [ "CoreFoundation.framework" ]
               ^-------------------------
  Use frameworks to list framework dependencies.
  See //llvm/test/BUILD.gn:205:5: which caused the file to be included.
      "//llvm/tools/dsymutil",
      ^----------------------


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85335

Files:
  llvm/utils/gn/secondary/llvm/tools/dsymutil/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/tools/dsymutil/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/tools/dsymutil/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/tools/dsymutil/BUILD.gn
@@ -30,6 +30,6 @@
     "dsymutil.cpp",
   ]
   if (host_os == "mac") {
-    libs = [ "CoreFoundation.framework" ]
+    frameworks = [ "CoreFoundation.framework" ]
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85335.283325.patch
Type: text/x-patch
Size: 413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200805/7f4d0634/attachment.bin>