[PATCH] D85104: [flang][NFC] Unify OpenMP and OpenACC structure checker
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 5 11:13:17 PDT 2020
clementval marked 2 inline comments as done.
clementval added a comment.
Thanks for the reviews. Will try to push that today.
================
Comment at: flang/lib/Semantics/check-directive-structure.h:30
+
+template <typename D, typename C, typename PC, std::size_t ClauseEnumSize>
+class DirectiveStructureChecker : public virtual BaseChecker {
----------------
ichoyjx wrote:
> Quick question, PC stands for?
`ParserClass` ... was trying to have short typename to not clutter the code too much. I'll add a comment on the class definition to mention what is what.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85104/new/
https://reviews.llvm.org/D85104
More information about the llvm-commits
mailing list