[PATCH] D85262: [llvm] Expose untyped accessor to evaluation result tensors

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 10:10:15 PDT 2020


mtrofin added a comment.

In D85262#2196818 <https://reviews.llvm.org/D85262#2196818>, @MaskRay wrote:

> The tag `[llvm] ` can be replaced by a more specific tag, e.g. TFUtils or some other abbreviation for the framework you are working on.

done



================
Comment at: llvm/include/llvm/Analysis/Utils/TFUtils.h:107
     EvaluationResult(EvaluationResult &&Other);
+    EvaluationResult &operator=(EvaluationResult &&Other);
+
----------------
MaskRay wrote:
> You can write `= default`
That doesn't work, the "impl" in the pImpl idiom is not available here. Just like the move ctor, the implementation needs to be in the .cpp file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85262/new/

https://reviews.llvm.org/D85262



More information about the llvm-commits mailing list