[PATCH] D85153: [lld-macho] Add .tbd support for frameworks

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 09:25:51 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:87
+static Optional<std::string>
+findWithAnyExtension(StringRef base, ArrayRef<StringRef> extensions) {
+  for (StringRef ext : extensions) {
----------------
compnerd wrote:
> The name makes it seem like it will match `base.*`.  What do you think of `findWithAllowedExtensions`?
`findWithExtensions`? Avoids the misleading `Any` and is shorter :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85153/new/

https://reviews.llvm.org/D85153



More information about the llvm-commits mailing list