[PATCH] D84639: AMDGPU: Add type mangling to llvm.amdgcn.readfirstlane

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

I think this makes sense, but it is a flag-day change for both Mesa and LLPC. Intrinsics created with incorrect mangling don't fall over completely (as evidenced by the fact that your change *doesn't* change the test files), but certain things like attributes tend to not work quite correctly anymore.

So I think we can still do this change, but please do all of `readlane`, `readfirstlane`, and `writelane` in a single change so that the pain is minimized.

You do have have to fix all test cases to use the correct mangling.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84639/new/

https://reviews.llvm.org/D84639