[PATCH] D81364: AMDGPU: Correct prolog SP initialization logic
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 5 08:52:21 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1297
+ // Callable functions always require a stack pointer reference.
+ if (!MF.getInfo<SIMachineFunctionInfo>()->isEntryFunction())
+ return true;
----------------
scott.linder wrote:
> Can this just be an assert that it is called for an entry function, and then could the name of this function just include `EntryFunction` like e.g. `emitEntryFunctionPrologue` does?
Yes, this is what I did originally but I decided a more wholistic function may be better for future uses
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81364/new/
https://reviews.llvm.org/D81364
More information about the llvm-commits
mailing list