[PATCH] D83779: [SLP] Fix order of `insertelement`/`insertvalue` seed operands

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 06:45:11 PDT 2020


RKSimon added a comment.

A couple of minor style comments - trivial scope reductions



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7090
+  auto *IE = dyn_cast<InsertElementInst>(InsertInst);
+  if (IE)
+    return IE->getType()->getNumElements();
----------------
if (auto *IE = dyn_cast<InsertElementInst>(InsertInst))


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7094
+  auto *IV = cast<InsertValueInst>(InsertInst);
+  AggregateSize = 1;
+  Type *CurrentType = IV->getType();
----------------
unsigned AggregateSize = 1;


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7121
+  auto *IE = dyn_cast<InsertElementInst>(InsertInst);
+  if (IE) {
+    if (auto *CI = dyn_cast<ConstantInt>(IE->getOperand(2))) {
----------------
if (auto *IE = dyn_cast<InsertElementInst>(InsertInst))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83779/new/

https://reviews.llvm.org/D83779



More information about the llvm-commits mailing list