[PATCH] D83216: [Intrinsic] Add sshl.sat/ushl.sat, saturated shift intrinsics.

Bevin Hansson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 05:13:01 PDT 2020


ebevhan added a comment.

In D83216#2196028 <https://reviews.llvm.org/D83216#2196028>, @lebedev.ri wrote:

> LGTM, but i would have preferred to see more feedback on the RFC thread.
> That being said, unless you are planning on forming calls to these intrinsics in middle-end transform passes
> (i.e. only planning on using them in clang codegen), i think this is okay to proceed.

At least for now, I'm not planning to emit them in middleend. I wanted to get most of the basic support in Clang and LLVM before looking at optimization.

However, based on the discussions in D82663 <https://reviews.llvm.org/D82663>, I am planning on sending an RFC for moving the fixed-point semantics and value class to LLVM, and adding a Builder class similar to the MatrixBuilder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83216/new/

https://reviews.llvm.org/D83216



More information about the llvm-commits mailing list