[PATCH] D82643: [AMDGPU] Remove -amdgpu-verify-regbanks-reassign
Carl Ritson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 5 03:21:12 PDT 2020
critson added a comment.
In D82643#2117280 <https://reviews.llvm.org/D82643#2117280>, @rampitec wrote:
> I like the alternative solution #1.
I also agree with alt. solution #1.
To me a key aspect of the verifier is ensuring that forward progress is taking place.
For the bugs I was recently encountering this was true because CyclesSaved was going up, but StallCycles was not going down equivalently.
Because this was an infinite loop, CyclesSaved would keep growing indefinitely and the verifier would catch this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82643/new/
https://reviews.llvm.org/D82643
More information about the llvm-commits
mailing list