[PATCH] D84817: Add verification for DW_AT_decl_file and DW_AT_call_file.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Latest update LGTM.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:84
+  if (FileNames.empty())
+    return llvm::None;
+  uint16_t DwarfVersion = getVersion();
----------------
Do you actually need the `llvm::` prefix here?


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes_no_files.yaml:19
+# CHECK:      Errors detected.
+--- !ELF
+FileHeader:
----------------
Nit: add a blank line before the YAML.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84817/new/

https://reviews.llvm.org/D84817