[PATCH] D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 5 00:17:10 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with optional nit.



================
Comment at: llvm/test/tools/llvm-objdump/MachO/universal-arm64.test:6
+# RUN: llvm-objdump %tarm.o --universal-headers --macho | \
+# RUN:   FileCheck %s --check-prefix=FAT --match-full-lines
+
----------------
Nit: as you only have one check prefix in this file, you can get rid of `--check-prefix` and just use the default `CHECK`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85041/new/

https://reviews.llvm.org/D85041



More information about the llvm-commits mailing list