[PATCH] D84825: [release/11.x only][ELF] Change tombstone value -1 to 0
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 4 23:32:07 PDT 2020
MaskRay added a comment.
> At which point we are at an impasse and the default behavior applies. Please revert completely back to the original behavior immediately.
>
> Thanks.
With respect I think the "request for changes" blocked the change and I am not inclined to agree we would otherwise be at an impasse without the "request for changes".
I would likely get an "Accept Revision" or a just textual "LGTM", even if there is a conditional request that ".debug_* should use 0 as well".
I sent the patch instead of reverting 3 or 4 dependent patches because I think reverting will just make the situation more confusing. I have experienced the review process and have read all the context,
so I very responsibly state again that "a simple revert of 3 or 4 dependent patches will just make the situation more confusing".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84825/new/
https://reviews.llvm.org/D84825
More information about the llvm-commits
mailing list