[PATCH] D71786: RFC: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}

[Mattias Jansson via Phabricator via llvm-commits]

maniccoder added inline comments.


================
Comment at: llvm/lib/Support/CMakeLists.txt:57
+if(LLVM_INTEGRATED_CRT_ALLOC MATCHES "rpmalloc$")
+  set(ALLOCATOR_FILES "${LLVM_INTEGRATED_CRT_ALLOC}/rpmalloc/rpmalloc.c" "${LLVM_INTEGRATED_CRT_ALLOC}/rpmalloc/malloc.c")
+elseif(LLVM_INTEGRATED_CRT_ALLOC MATCHES "snmalloc$")
----------------
hans wrote:
> I thought rpmalloc/malloc.c isn't supposed to be compiled on its own, but gets included into rpmalloc.c when ENABLE_OVERRIDE is defined. I'm guessing the could explain Russell's compiler error above.
Also seems like the ENABLE_OVERRIDE define is missing, must be defined to 1 to enable the malloc/free and new/delete replacement in rpmalloc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786