[PATCH] D85257: [X86] Optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures'

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 17:17:51 PDT 2020


nickdesaulniers added a comment.

In D85257#2194952 <https://reviews.llvm.org/D85257#2194952>, @nickdesaulniers wrote:

> I suspect `setFeatureEnabled` is being called for every global.

Ah, it looks like `clang::Parser::ParseAsmStatement`, so each inline asm statement is problematic.   I guess that's no surprise for the kernel.  There's another call from `ParseAsmStatement` that then calls `clang::targets::X86TargetInfo::initFeatureMap`, but I can't see it (the type signature overflows in `perf report`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85257/new/

https://reviews.llvm.org/D85257



More information about the llvm-commits mailing list