[PATCH] D85257: [X86] Optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures'

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

Thanks for the patch, I'm happy to test it out.



================
Comment at: llvm/lib/Support/X86TargetParser.cpp:101-104
+    for (unsigned I = 0, E = array_lengthof(Bits); I != E; ++I)
+      if (Bits[I] != RHS.Bits[I])
+        return false;
+    return true;
----------------
are these more concise to `return llvm::any_of` here and above?


================
Comment at: llvm/lib/Support/X86TargetParser.cpp:576
+        Bits |= FeatureInfos[i].ImpliedFeatures;
+  } while (!(Prev == Bits));
 }
----------------
can we not use `!=` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85257/new/

https://reviews.llvm.org/D85257