[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added subscribers: Nathan-Huckleberry, nickdesaulniers.
nickdesaulniers added a comment.

Hi @craig.topper , @Nathan-Huckleberry and I are seeing `getImpliedEnabledFeatures` at the top of our profiles now.  It seems that `llvm::X86::getImpliedFeatures` is repeatedly queried for the same inputs.  Should we try to cache the `ImpliedBits` query or try to have `X86TargetInfo::setFeatureEnabled` not rebuild `ImpliedBits` every invocation?  FWIW, I'm seeing `getImpliedEnabledFeatures` take 2.33% of compilation for the median duration to build input file from the x86 Linux kernel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83273/new/

https://reviews.llvm.org/D83273