[PATCH] D84206: [llvm-libtool-darwin] Add support for -filelist option

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:78
+      sys::path::append(Path, Line);
+    InputFiles.push_back(Twine(Path).str());
+  }
----------------
Nit: SmallString has an `operator std::string`, so you should be able to convert directly without the intermediate Twine. I'm not sure if just `InputFiles.push_back(Path)` will compile, but a cast should definitely trigger the conversion, e.g. `InputFiles.push_back(static_cast<std::string>(Path))`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84206/new/

https://reviews.llvm.org/D84206