[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 14:43:42 PDT 2020


hoyFB marked 3 inline comments as done.
hoyFB added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:211
+
+.. code-block:: none
+    cmp eax, dword ptr [rip + 4112]
----------------
jhenderson wrote:
> As this is associated with the option, it needs indenting with a couple of spaces, just like the text describing the option. Same goes below. If you take a look at the output, you'll see that adding a couple of spaces before should cause the code to be shifted slightly to the right.
Done adding indentation.

BTW, how should I see the the out of the `.rst` file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191



More information about the llvm-commits mailing list