[PATCH] D85183: [llvm-rc] Allow string table values split into multiple string literals
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 4 12:31:03 PDT 2020
mstorsjo added inline comments.
================
Comment at: llvm/tools/llvm-rc/ResourceFileWriter.h:106
struct Bundle {
- std::array<Optional<StringRef>, 16> Data;
+ std::array<Optional<std::vector<StringRef>>, 16> Data;
ObjectInfo DeclTimeInfo;
----------------
mstorsjo wrote:
> amccarth wrote:
> > Would it be more straightforward to represent the string as a Twine rather than a vector for StringRefs?
> No - we need the individual strings stored separarely as we need to call `processString` on each of them on their own.
Oh, and also, Twines can't be stored, as they basically just consist of references to the temporary twines/objects that they're concatenated from.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85183/new/
https://reviews.llvm.org/D85183
More information about the llvm-commits
mailing list