[PATCH] D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 12:24:50 PDT 2020


MaskRay added a comment.

In D83530#2194261 <https://reviews.llvm.org/D83530#2194261>, @MaskRay wrote:

> In D83530#2193865 <https://reviews.llvm.org/D83530#2193865>, @RKSimon wrote:
>
>> @maskray http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/33877/ is failing with the error:
>>
>>   $ "c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\build\bin\llvm-symbolizer.exe" "-obj=c:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm-project\llvm\test\tools\llvm-symbolizer\pdb/Inputs/test.exe" "-demangle=false"
>>   # command stderr:
>>   error: unknown argument '-demangle=false'
>
> Fixing

Fixed in 0729a772806e5ae38603c164c2f60e5e9f9e65e5 <https://reviews.llvm.org/rG0729a772806e5ae38603c164c2f60e5e9f9e65e5>. I don't have Windows or HAVE_DIA_SDK to test it, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83530/new/

https://reviews.llvm.org/D83530



More information about the llvm-commits mailing list