[PATCH] D84913: [libFuzzer] Enable for SystemZ
Ilya Leoshkevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 4 11:28:15 PDT 2020
iii marked 5 inline comments as done.
iii added inline comments.
================
Comment at: compiler-rt/lib/fuzzer/FuzzerTracePC.h:196
// Iterate by Step bytes at a time.
- for (; P < End; P += Step)
- if (LargeType Bundle = *reinterpret_cast<const LargeType *>(P))
+ for (; P < End; P += Step) {
+ if (LargeType Bundle = *reinterpret_cast<const LargeType *>(P)) {
----------------
kcc wrote:
> please remove the { that weren't there.
ok
================
Comment at: compiler-rt/lib/fuzzer/FuzzerUtil.h:110
+#if __BYTE_ORDER == __LITTLE_ENDIAN
+template <typename T> T htole(T X) { return X; }
+#else
----------------
kcc wrote:
> Maybe name it HostToLE?
Ok - clang-tidy might not like it, but let's see.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84913/new/
https://reviews.llvm.org/D84913
More information about the llvm-commits
mailing list