[PATCH] D84913: [libFuzzer] Enable for SystemZ

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 10:31:34 PDT 2020


kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

Please fix two nits, then good to go. 
Thanks!



================
Comment at: compiler-rt/lib/fuzzer/FuzzerTracePC.h:196
   // Iterate by Step bytes at a time.
-  for (; P < End; P += Step)
-    if (LargeType Bundle = *reinterpret_cast<const LargeType *>(P))
+  for (; P < End; P += Step) {
+    if (LargeType Bundle = *reinterpret_cast<const LargeType *>(P)) {
----------------
please remove the { that weren't there. 


================
Comment at: compiler-rt/lib/fuzzer/FuzzerUtil.h:110
+#if __BYTE_ORDER == __LITTLE_ENDIAN
+template <typename T> T htole(T X) { return X; }
+#else
----------------
Maybe name it HostToLE? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84913/new/

https://reviews.llvm.org/D84913



More information about the llvm-commits mailing list