[PATCH] D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:443-445
+  // Build up the expression (SP + NumBytes + NumVGScaledBytes * AArch64::VG)
+  SmallString<64> Expr;
+  Expr.push_back(dwarf::DW_OP_breg0 + /*SP*/ 31);
----------------
rupprecht wrote:
> I'm seeing the following warning here:
> 
> ```
> [723/2438] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64FrameLowering.cpp.o
> /home/rupprecht/src/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:445:37: warning: implicit conversion from 'int' to 'const char' changes value from 143 to -113 [-Wconstant-conversion]
>   Expr.push_back(dwarf::DW_OP_breg0 + /*SP*/ 31);
>        ~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> 1 warning generated.
> ```
> 
> Do you see it as well? Is there a way to silence it?
Sorry, I don't see this warning. What compiler are you using?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84043/new/

https://reviews.llvm.org/D84043