[PATCH] D85139: [GlobalISel] Don't transform FSUB(-0, X) -> FNEG(X) in GlobalISel.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 4 09:25:43 PDT 2020


cameron.mcinally added a comment.

In D85139#2193065 <https://reviews.llvm.org/D85139#2193065>, @arsenm wrote:

> I think this leaves behind a redundant test_fneg/test_fneg_fmf case elsewhere

You're probably right. Just took a look and I don't see anything obvious though. Did you have a particular set of tests in mind?

I do see some tests that transform an illegal G_FNEG into an G_FSUB. I don't fully understand the motivation yet, but that's probably worth attention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85139/new/

https://reviews.llvm.org/D85139



More information about the llvm-commits mailing list