[PATCH] D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 3 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/AArch64/macho-arm64-v8.test:1
+# RUN: yaml2obj %s -o %tarm-v8.o
+# RUN: llvm-objdump -p %tarm-v8.o | FileCheck --strict-whitespace %s
----------------
jhenderson wrote:
> Rather than add a test nearly identical to `macho-arm64e.test`, what do you think about renaming that test to `macho-arm64-subtypes.test` (or something similar) and merging the two (optionally with an explicit testing of the `ALL` subtype, but that's not so important since there's coverage elsewhere)
Yeah, I agree. Updated it now, thanks!


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:2112-2115
+    case MachO::CPU_SUBTYPE_ARM64_V8:
+      outs() << "    cputype CPU_TYPE_ARM64\n";
+      outs() << "    cpusubtype CPU_SUBTYPE_ARM64_V8\n";
+      break;
----------------
jhenderson wrote:
> This code-path doesn't seem to have any testing? The new objdump test only covers the other change in this file by my reading.
True. Added a test for them while printing universal headers now (similar to `universal-x86_64.i386.test`) Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85041/new/

https://reviews.llvm.org/D85041