[PATCH] D85212: Add parser support for OpenMP allocate clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks @Rin for this patch. A few minor comments.



================
Comment at: flang/include/flang/Parser/parse-tree.h:3498
       OmpIfClause, OmpLinearClause, OmpMapClause, OmpProcBindClause,
-      OmpReductionClause, OmpScheduleClause>
+      OmpReductionClause, OmpAllocateClause, OmpScheduleClause>
       u;
----------------
Are the Omp*Clauses in alphabetic order?


================
Comment at: flang/lib/Parser/openmp-parsers.cpp:213
         construct<OmpClause>(parenthesized(Parser<OmpReductionClause>{})) ||
+
+    "ALLOCATE" >> 
----------------
Nit: Extraneous line?


================
Comment at: flang/test/Semantics/omp-clause-validity01.f90:31
 
-  !$omp parallel
+  !$omp parallel 
+  do i = 1, N
----------------
Nit:extra character (at end of line)?


================
Comment at: flang/test/Semantics/omp-clause-validity01.f90:43
+
+  !$omp parallel allocate(omp_default_mem_space : b, c)
+  do i = 1, N
----------------
Did a custom allocator test work fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85212/new/

https://reviews.llvm.org/D85212