[PATCH] D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

>From the [0], I've understood that this should affect debug build only (-g + -O0) ?

[0] http://lists.llvm.org/pipermail/llvm-dev/2020-April/140962.html



================
Comment at: llvm/test/DebugInfo/X86/DW_AT_start_scope.ll:10
+
+; c source code for this IR
+; int main(int Argc, char **Argv) {
----------------
This should also be ';;'.


================
Comment at: llvm/test/DebugInfo/X86/DW_AT_start_scope.ll:67
+
+attributes #0 = { noinline nounwind optnone uwtable }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
Usually we don't need these attributes.


================
Comment at: llvm/test/DebugInfo/X86/DW_AT_start_scope.ll:101
+!25 = !DILocalVariable(name: "Local", scope: !23, file: !1, line: 7, type: !10)
+!26 = !DILocation(line: 7, column: 6, scope: !23)
+!27 = !DILocation(line: 8, column: 16, scope: !23)
----------------
Probably you can attach all these to the same di-location (with the same scope).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85018/new/

https://reviews.llvm.org/D85018